Messages in this thread | | | Date | Sun, 28 Aug 2011 09:53:22 +0200 | Subject | Re: m68k: [v5] Convert to genirq (WIP) | From | Geert Uytterhoeven <> |
| |
On Sun, Aug 28, 2011 at 04:08, Finn Thain <fthain@telegraphics.com.au> wrote: > On Fri, 26 Aug 2011, Geert Uytterhoeven wrote: >> - [PATCH 18/24]: m68k/mac: Optimize interrupts using chain handlers (NEW) > > That patch has a mistake -- > > irq_set_chained_handler(IRQ_AUTO_4, psc_irq); > irq_set_handler_data(IRQ_AUTO_3, (void *)0x40); > irq_set_chained_handler(IRQ_AUTO_5, psc_irq); > irq_set_handler_data(IRQ_AUTO_3, (void *)0x50); > irq_set_chained_handler(IRQ_AUTO_6, psc_irq); > irq_set_handler_data(IRQ_AUTO_3, (void *)0x60); > > should be > > irq_set_chained_handler(IRQ_AUTO_4, psc_irq); > irq_set_handler_data(IRQ_AUTO_4, (void *)0x40); > irq_set_chained_handler(IRQ_AUTO_5, psc_irq); > irq_set_handler_data(IRQ_AUTO_5, (void *)0x50); > irq_set_chained_handler(IRQ_AUTO_6, psc_irq); > irq_set_handler_data(IRQ_AUTO_6, (void *)0x60);
Woops, of course. Thanks!
> On one VIA-based machine that I tested, !CONFIG_USE_GENERIC_HARDIRQS > gives: > > # cat /proc/interrupts > auto 1: 2299 via1 > auto 2: 3876 via2 > auto 4: 562 SCC > auto 7: 0 NMI > mac 10: 590 pmu-shift > mac 12: 90 pmu-clock > mac 14: 1635 timer > mac 17: 3876 nubus > mac 56: 3879 sonic > > whereas, CONFIG_USE_GENERIC_HARDIRQS=y gives: > > # cat /proc/interrupts > CPU0 > 4: 5303 auto SCC > 7: 0 auto NMI > 10: 2136 mac pmu-shift > 12: 607 mac pmu-clock > 14: 41858 mac timer > 56: 66876 mac sonic > ERR: 0 > > Are there no counters for chained IRQs?
I noticed the same for Amiga.
> Other than these issues everything looks OK. I will test OSS and Baboon > when I get the relevant hardware set up.
Thanks again!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |