[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] .gitattributes: Enable cpp diff parsing for .[ch] files
Linus Torvalds <> writes:

> On Thu, Aug 25, 2011 at 3:37 PM, Boaz Harrosh <> wrote:
>> Add a .gitattributes file to the Linux tree to enable cpp parsing
>> of the source files.
> Hmm. I'm not entirely conviced. If people really think that the hunk
> description matters that much, maybe we should just instead improve on
> the automatic diff detection, and extend it from just binary-vs-text,
> to also do the common hunk-headers.
> After all, not having a diff pattern already *does* mean "automatic",
> so it would be just a rather trivial extension to that.

Not quite sure what you exactly mean by "extend it from just binary-vs-text".
Do you mean update buffer_is_binary() and add source language detection?

See also:

 \ /
  Last update: 2011-08-26 22:57    [W:0.078 / U:4.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site