lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Power-supply]: Error handling in max17042_battery.c
Sender : Pallala, Ramakrishna<ramakrishna.pallala@intel.com> Date : 2011-08-26 14:46 (GMT+09:00)
> Hi All,
>
> I am working on the I2C based max17042 fuel gauge driver
> Which is drivers/power/max17042_battery.c
>
> In max17042_get_property(...), the values returned by
> Max17042_read_reg are directly assigned to the variables,
> even if the read results in an error. Shouldn't we check
> for the 'correctness' of the returned values and then
> assign them ? Can I submit a patch to change this ?
>
> Or Is this done intentionally ?
>
> Thanks,
> Ram
>

Hello,

I did not ignore and return the error values from max17042_read_reg() intentionally, I've just missed them somehow (maybe was too lazy that day?).

Handling errors from max17042_read_reg() at the side of max17042_get_property() is a feature missing. And, I'd be much appreciated if you'd send the patch you've mentioned.

Thank you,
MyungJoo
\
 
 \ /
  Last update: 2011-08-26 08:35    [W:0.052 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site