lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Smack: SMACK_IOCLOADACCESS
    From
    Date
    On Fri, 2011-08-26 at 14:14 +0100, Alan Cox wrote:
    > > good in that it only takes 1 syscall and ours takes 2. Your interface
    > > is bad in that it is ioctl and we are told since birth that we must
    > > hate them no matter what (not that read/write is really any
    > > different). It isn't the same method the only other LSM I know about
    > > uses. It can only every return one value (ok, I know ioctl can be
    > > made to do anything at all)
    >
    > I'm all in favour of the use of brains rather than the cult of ioctl
    > hating. You can design bad ioctls and good ones. Also ioctl is pretty
    > much unique in being bidirectional, it allows a query/respose action
    > without having to worry about whether the respose is the one to your
    > query or another parallel query.

    The transaction ops achieve that property as well - the response is
    stored in an open file private buffer and thus can only correspond to a
    request written to that same open file instance.

    --
    Stephen Smalley
    National Security Agency



    \
     
     \ /
      Last update: 2011-08-26 19:39    [W:0.020 / U:89.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site