lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: linux-next: Tree for Aug 25
> 
> On 8/26/2011 12:26 AM, Randy Dunlap wrote:
> >
> > On Wed, August 24, 2011 11:35 pm, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> The powerpc allyesconfig build still fails today.
> >
> >
> > CONFIG_FCOE is not enabled:
> >
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_net_config':
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:765: error: 'NETDEV_FCOE_WWNN'
> > undeclared (first use in this function)
> > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:771: error: 'NETDEV_FCOE_WWPN'
> > undeclared (first use in this function)
> >
> >
> > Maybe this driver should select FCOE?
> bnx2fc does not depend on FCOE. Instead both fcoe and bnx2fc drivers
> depend on LIBFCOE. So, I'll modify to access
> NETDEV_FCOE_WWNN/NETDEV_FCOE_WWPN when CONFIG_LIBFCOE is enabled.
>
Yes, both these two flags and ndo_fcoe_get_wwn() should be wrapped by
CONFIG_LIBFCOE || CONFIG_LIBFCOE_MODULE as bnx2fc is also using the get_wwn
hook I believe. Historically on fcoe module was using them.

> Patch will be submitted soon.
Thanks,
yi

>
> Thanks,
> Bhanu

> >
> > ~Randy
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2011-08-26 19:01    [W:0.061 / U:2.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site