lkml.org 
[lkml]   [2011]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2
    On Fri, Aug 26, 2011 at 03:28:51PM +0300, Kirill A. Shutemov wrote:
    ...
    > >
    > > -static int proc_cwd_link(struct inode *inode, struct path *path)
    > > +static int proc_cwd_link(struct dentry *dentry, struct inode *inode, struct path *path)
    >
    > Put proc_get_link() change in separate patch?
    >

    Will do, but let leave it to a final pass, ie when all get agreed on idea and
    details, ok? Since I'll be re-sending the final version seraparely anyway.
    ...
    > > + down_read(&mm->mmap_sem);
    > > +
    > > + nr_files = 0;
    > > + for (vma = mm->mmap; vma; vma = vma->vm_next) {
    > > + if (vma->vm_file)
    > > + nr_files++;
    > > + }
    > > + if (!nr_files)
    > > + goto out;
    >
    > up_read(&mm->mmap_sem); ?
    >
    > > +
    > > + info = kmalloc(nr_files * sizeof(*info), GFP_KERNEL);
    > > + if (!info) {
    > > + ret = -ENOMEM;
    > > + goto out;
    >
    > Ditto.
    >

    Yeah, thanks Kirill!


    \
     
     \ /
      Last update: 2011-08-26 14:41    [W:0.031 / U:92.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site