| Date | Thu, 25 Aug 2011 20:02:44 +0200 | From | Pawel Jakub Dawidek <> | Subject | Re: [Drbd-dev] [PATCH 016/118] drbd: Add read_requests tree |
| |
On Thu, Aug 25, 2011 at 05:07:12PM +0200, Philipp Reisner wrote: > From: Andreas Gruenbacher <agruen@linbit.com> > > We do not do collision detection for read requests, but we still need to > look up the request objects when we receive a package over the network. > Using the same data structure for read and write requests results in > simpler code once the tl_hash and app_reads_hash tables are removed. > > Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> > Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com> > --- > drivers/block/drbd/drbd_int.h | 1 + > drivers/block/drbd/drbd_main.c | 1 + > drivers/block/drbd/drbd_req.c | 13 ++++++++++--- > 3 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h > index 0583713..fe15319 100644 > --- a/drivers/block/drbd/drbd_int.h > +++ b/drivers/block/drbd/drbd_int.h > @@ -1020,6 +1020,7 @@ struct drbd_conf { > unsigned int tl_hash_s; > > /* Interval tree of pending local write requests */ > + struct rb_root read_requests; > struct rb_root write_requests;
Looks like the comment needs updating.
-- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com [unhandled content-type:application/pgp-signature] |