lkml.org 
[lkml]   [2011]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2
On Thu, Aug 25, 2011 at 21:39 +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 25, 2011 at 09:36:42PM +0400, Vasiliy Kulikov wrote:
> ...
> > > +
> > > + result = ERR_PTR(-EPERM);
> > > + if (!ptrace_may_access(task, PTRACE_MODE_READ));
> > > + goto out_no_mm;
> >
> > Probably
> >
> > result = ERR_PTR(-ENOENT);
> >
> > belongs here?
> >
>
> Don't think so, it should point that permission failed
> rather no such entry. Or this might break some tools?

I mean the place exactly where I've put it to indicate simple_strtoul(),
get_task_mm(), or find_exact_vma() error. EPERM for ptrace_may_access()
is OK.

Thanks,

--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments


\
 
 \ /
  Last update: 2011-08-25 19:57    [W:0.118 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site