Messages in this thread | | | Date | Wed, 24 Aug 2011 09:54:33 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 4/6] cgroup: don't use subsys->can_attach_task() or ->attach_task() |
| |
Hello,
On Tue, Aug 23, 2011 at 06:57:39PM -0700, Matt Helsley wrote: > On Wed, Aug 24, 2011 at 12:19:58AM +0200, Tejun Heo wrote: > > <snip> > > > * In cgroup_freezer, remove unnecessary NULL assignments to unused > > methods. It's useless and very prone to get out of sync, which > > already happened. > > You could post this part independently -- that might be best since > I guess the taskset bits will need more discussion.
Urgh... I really think subsystems which aren't very isolated should have its own tree. Going through -mm works well if the changes are isolated or all inter-dependent changes go through -mm too but it stops working as soon as the changes start span across other git trees. If cgroup isn't expected to see a lot of changes in this cycle (if so, please set up a git tree, it isn't difficult), the best solution, I think, would be sticking w/ Rafael's branch.
Thanks.
-- tejun
| |