lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [Patch] Scm: Remove unnecessary pid & credential references in Unix socket's send and receive path
    From
    From: Tim Chen <tim.c.chen@linux.intel.com>
    Date: Mon, 22 Aug 2011 17:57:26 -0700

    > On Mon, 2011-08-22 at 17:40 -0700, David Miller wrote:
    >> From: Tim Chen <tim.c.chen@linux.intel.com>
    >> Date: Fri, 19 Aug 2011 09:44:58 -0700
    >>
    >> > - /* Only send the fds in the first buffer */
    >> > - err = unix_scm_to_skb(siocb->scm, skb, !fds_sent);
    >> > + /* Only send the fds and no ref to pid in the first buffer */
    >> > + if (fds_sent)
    >> > + err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, true);
    >> > + else
    >> > + err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, false);
    >>
    >> Just set this final boolean the way the third argument is, there is no
    >> reason to replicate the entire function call twice just to set the
    >> final argument to what "fds_sent" evaluates to as a boolean.
    >>
    >> err = unix_scm_to_skb(siocb->scm, skb, !fds_sent, fds_sent);
    >>
    >> ought to suffice.
    >
    > Good point. Patch updated as suggested.

    Applied.


    \
     
     \ /
      Last update: 2011-08-25 04:45    [W:0.023 / U:30.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site