lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 7/7] Input: elantech - add v3 hardware support
    Date
    Hi Seth,

    Thank you. You are right.
    I think I somehow tested the worng touchpad for this patch.

    jj

    On Wed, 24 Aug 2011 09:35:20 -0500, Seth Forshee <seth.forshee@canonical.com> wrote:
    > On Wed, Aug 24, 2011 at 01:44:46PM +0800, JJ Ding wrote:
    > > @@ -403,11 +503,39 @@ static int elantech_packet_check_v2(struct psmouse *psmouse)
    > > }
    > >
    > > /*
    > > + * We check the constant bits to determine what packet type we get,
    > > + * so packet checking is mandatory for v3 hardware.
    > > + */
    > > +static int elantech_packet_check_v3(struct psmouse *psmouse)
    > > +{
    > > + unsigned char *packet = psmouse->packet;
    > > +
    > > + if ((packet[0] & 0x0c) == 0x04 &&
    > > + (packet[3] & 0xcf) == 0x02)
    > > + return PACKET_V3_HEAD;
    > > +
    > > + if ((packet[0] & 0x0c) == 0x0c &&
    > > + (packet[3] & 0xce) == 0x0c)
    > > + return PACKET_V3_TAIL;
    > > +
    > > + if (packet[0] == 0xc4 &&
    > > + packet[1] == 0xff &&
    > > + packet[2] == 0xff &&
    > > + packet[3] == 0x02 &&
    > > + packet[4] == 0xff &&
    > > + packet[5] == 0xff)
    > > + return PACKET_DEBOUNCE;
    > > +
    > > + return PACKET_UNKNOWN;
    > > +}
    >
    > This will never return PACKET_DEBOUNCE, because those packets will have
    > already matched the conditions for PACKET_V3_HEAD. That condition needs
    > to be moved to the top of the function.
    >
    > Seth


    \
     
     \ /
      Last update: 2011-08-25 03:09    [W:0.025 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site