lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the final tree (staging tree related)
On Thu, Aug 25, 2011 at 08:54:20AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > To fix it, all we have to do is include linux/vmalloc.h, right? Or is
>
> I would assume so.
>
> > ppc "special" in some other way regarding this call?
>
> I assume it happens just because vmalloc.h is implicitly included by some
> other header file on x86 and not on ppc.
>
> This is why we have "Rule 1" in Documentation/SubmitChecklist. Relying
> on the implicit inclusion of header files is bound to trip us up on some
> architecture or platform or combination of CONFIG options.

Fair enough, I've made this fix in my tree, so it should be good now.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-08-25 01:01    [W:0.058 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site