lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/4] drivers/staging/usbip/userspace/libsrc/vhci_driver.c: test the just-initialized value
    From
    2011/8/22 Julia Lawall <julia@diku.dk>:
    > From: Julia Lawall <julia@diku.dk>
    >
    > Test the just-initialized value rather than some other one.
    >
    > The semantic match that finds this problem is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @r@
    > identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
    > statement S;
    > @@
    >
    > x = f(...);
    > (
    > if (\(x == NULL\|IS_ERR(x)\)) S
    > |
    > *if (\(y == NULL\|IS_ERR(y)\))
    >  { ... when != x
    >   return ...; }
    > )
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>
    >
    > ---
    >  drivers/staging/usbip/userspace/libsrc/vhci_driver.c |    2 +-
    >  1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
    > index abbc285..2697877 100644
    > --- a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
    > +++ b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
    > @@ -133,7 +133,7 @@ static int check_usbip_device(struct sysfs_class_device *cdev)
    >                             strlen(vhci_driver->hc_device->path))) {
    >                        /* found usbip device */
    >                        usbip_cdev = calloc(1, sizeof(*usbip_cdev));
    > -                       if (!cdev) {
    > +                       if (!usbip_cdev) {
    >                                dbg("calloc failed");
    >                                return -1;
    >                        }
    >

    Acked-by: David Chang <dchang@suse.com>

    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-08-23 07:01    [W:0.023 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site