Messages in this thread | | | Subject | RE: [PATCH] DMA: PL330: add missing header | From | "Koul, Vinod" <> | Date | Tue, 23 Aug 2011 13:45:42 +0530 |
| |
On Tue, 2011-08-23 at 16:19 +0900, Boojin Kim wrote: > Koul, Vinod wrote: > > Sent: Tuesday, August 23, 2011 3:32 PM > > To: Boojin Kim > > Cc: linux-kernel@vger.kernel.org; Kukjin Kim > > Subject: Re: [PATCH] DMA: PL330: add missing header > > > > On Tue, 2011-08-23 at 14:57 +0900, Boojin Kim wrote: > > > This patch fixup below build error > > > > > > drivers/dma/pl330.c: In function 'pl330_prep_slave_sg': > > > drivers/dma/pl330.c:603: error: implicit declaration of function > > 'for_each_sg' > > > drivers/dma/pl330.c:603: error: expected ';' before '{' token > > > drivers/dma/pl330.c:581: warning: unused variable 'flags' > > > drivers/dma/pl330.c: In function 'pl330_probe': > > > drivers/dma/pl330.c:720: warning: comparison of distinct pointer > > types lacks a cast > > > make[2]: *** [drivers/dma/pl330.o] Error 1 > > > > > > Signed-off-by: Boojin Kim <boojin.kim@samsung.com> > > > --- > > > drivers/dma/pl330.c | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > > > index 00eee59..fcad90c 100644 > > > --- a/drivers/dma/pl330.c > > > +++ b/drivers/dma/pl330.c > > > @@ -17,6 +17,7 @@ > > > #include <linux/interrupt.h> > > > #include <linux/amba/bus.h> > > > #include <linux/amba/pl330.h> > > > +#include <linux/scatterlist.h> > > > > > > #define NR_DEFAULT_DESC 16 > > > > > Where tree is this error reported? scatterlist.h is already added to > > the > > dmaengine.h > Oops, I founded it just now in your tree. > OK, please kindly drop this. > As a note, since happens build error with latest mainline v3.1-rc3 so that > should be merged for v3.1. Russell had fixed compilation of pl330 driver, and was supposed to send the fix to Linus as part of his fixes. If thats not done I can send it for next -rc
-- ~Vinod
| |