lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCHv4 1/4] usb: Provide usb_speed_string() function
    From
    On Tue, Aug 23, 2011 at 1:28 AM, Alan Stern <stern@rowland.harvard.edu> wrote:
    > On Mon, 22 Aug 2011, Michal Nazarewicz wrote:
    >
    >> From: Michal Nazarewicz <mina86@mina86.com>
    >>
    >> In a few places in the kernel, the code prints
    >> a human-readable USB device speed (eg. "high speed").
    >> This involves a switch statement sometimes wrapped
    >> around in ({ ... }) block leading to code repetition.
    >>
    >> To mitigate this issue, this commit introduces
    >> usb_speed_string() function, which returns
    >> a human-readable name of provided speed.
    >>
    >> It also changes a few places switch was used to use
    >> this new function.  This changes a bit the way the
    >> speed is printed in few instances at the same time
    >> standardising it.
    >
    >> --- a/drivers/usb/Makefile
    >> +++ b/drivers/usb/Makefile
    >> @@ -51,3 +51,6 @@ obj-$(CONFIG_USB_MUSB_HDRC) += musb/
    >>  obj-$(CONFIG_USB_RENESAS_USBHS)      += renesas_usbhs/
    >>  obj-$(CONFIG_USB_OTG_UTILS)  += otg/
    >>  obj-$(CONFIG_USB_GADGET)     += gadget/
    >> +
    >> +obj-$(CONFIG_USB)            += common.o
    >> +obj-$(CONFIG_USB_GADGET)     += common.o
    >
    > Will this cause problems?  For example, what if CONFIG_USB is Y and
    > CONFIG_USB_GADGET is M?
    >
    > Also, it seems a little silly to have an entire kernel module devoted
    > to a single, little function.  This is a symptom of the difficulty of
    > sharing code between the host-side and gadget-side USB stacks.
    >

    How about put the code as inline function in ch9.h?

    > Alan Stern
    >
    >



    --
    Regards
    Yang RuiRui
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-08-24 04:19    [W:0.024 / U:0.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site