lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code
    Date


    > -----Original Message-----
    > From: Greg KH [mailto:greg@kroah.com]
    > Sent: Tuesday, August 23, 2011 6:50 PM
    > To: KY Srinivasan
    > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
    > Subject: Re: [PATCH 019/117] Staging: hv: vmbus: Cleanup vmbus_uevent() code
    >
    > On Fri, Jul 15, 2011 at 10:46:07AM -0700, K. Y. Srinivasan wrote:
    > > Now generate appropriate uevent based on the modalias string. As part of this,
    > > cleanup the existing uevent code.
    >
    > Note, you just change the user api here, did you have tools that relied
    > on the old format? If so, they just broke :(

    Prior to this, I don't think autoloading worked the way it should for these
    modules.

    >
    > > + for (i = 0; i < (sizeof(struct hv_vmbus_device_id) * 2); i += 2)
    > > + sprintf(&alias_name[i], "%02x", dev->dev_type.b[i/2]);
    >
    > Don't we have a type for printing out a uuid already?

    I did not see one; could you point me to the right place.
    >
    > And what's with the jumping by 2 yet dividing? What am I missing here?

    Each byte of the uuid is represented by 2 bytes in the string; thus the magic with 2.

    Regards,

    K. Y



    \
     
     \ /
      Last update: 2011-08-24 02:41    [W:0.024 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site