lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 017/117] Staging: hv: mouse: Do not auto-load the mouse driver
    On Fri, Jul 15, 2011 at 10:46:05AM -0700, K. Y. Srinivasan wrote:
    > The mouse driver is not functional and so, prevent auto-loading
    > of this driver. Earlier we added the MODULE_DEVICE_TABLE() line
    > to verify that the appropriate module alias was generated.
    >
    > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    > ---
    > drivers/staging/hv/hv_mouse.c | 5 ++++-
    > 1 files changed, 4 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
    > index d6441d6..95986fb 100644
    > --- a/drivers/staging/hv/hv_mouse.c
    > +++ b/drivers/staging/hv/hv_mouse.c
    > @@ -931,7 +931,10 @@ static const struct hv_vmbus_device_id id_table[] = {
    > },
    > };
    >
    > -MODULE_DEVICE_TABLE(vmbus, id_table);
    > +/*
    > + * The mouse driver is not functional; do not auto-load it.
    > + */
    > +/* MODULE_DEVICE_TABLE(vmbus, id_table); */

    Then you should not have caused it to be autoloaded on the previous
    patch. Please merge this with the previous patch, which would be merged
    with the previous patch to that, smushing them all into a smaller patch
    series.

    greg k-h


    \
     
     \ /
      Last update: 2011-08-24 01:43    [W:0.020 / U:30.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site