| Date | Tue, 23 Aug 2011 15:27:38 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c. |
| |
On Mon, Aug 15, 2011 at 08:24:27PM -0400, Akshay Joshi wrote: > Split the case statement and the code that is executed if the condition > is met so that it passes checkpatch.pl and conforms to the kernel code > style.
Not quite.
Please put the 'break;' on a new line for every case statement.
Care to redo this whole series based on the review comments you got so far and resend them?
thanks,
greg k-h
|