Messages in this thread | | | Date | Tue, 23 Aug 2011 14:44:21 -0700 | From | Greg KH <> | Subject | Re: [PATCH v2] Staging: cx25821: fix coding style issues |
| |
On Tue, Aug 02, 2011 at 05:03:18PM +0800, Leonid V. Fedorenchik wrote: > Fix too long lines in cx25821-audio.h > Fix wrong brace placement in cx25821-cards.c, cx25821-core.c, > and cx25821-i2c.c > Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl. > Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place. > Delete file cx25821-gpio.h since it is not used. > Get rid of typedef in cx25821.h.
I prefer to get patches in a "one patch per thing you did" format.
So, care to split this up into a number of smaller patches, all doing the individual thing you list above?
Yes, it's going to be a bunch of small patches, but then they will be "obviously" correct and trivial to review and apply.
thanks,
greg k-h
| |