lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree
Ben, Kumar, can one of you take a look at my question and help me out?

wrote:
> On Mon, Aug 8, 2011 at 7:18 AM, Julia Lawall <julia@diku.dk> wrote:
>
>> diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c
>> index af1a5df..b6731e4 100644
>> --- a/arch/powerpc/sysdev/ehv_pic.c
>> +++ b/arch/powerpc/sysdev/ehv_pic.c
>> @@ -280,6 +280,7 @@ void __init ehv_pic_init(void)
>>
>> if (!ehv_pic->irqhost) {
>> of_node_put(np);
>> + kfree(ehv_pic);
>> return;
>> }
>
> Although the fix is correct, I think there is another bug in this
> function. 'np' is not released when the function finishes
> successfully. I've looked at other functions that use
> irq_alloc_host(), and most of them do the same thing: they don't call
> of_node_put() on the device node pointer. The only exception I've
> found is mpc5121_ads_cpld_pic_init().
>
> Ben, Kumar: am I missing something? irq_alloc_host() calls of_node_get():
>
> host->of_node = of_node_get(of_node);
>
> so doesn't that mean that the caller of irq_alloc_host() should
> release the device node pointer?
>


--
Timur Tabi
Linux kernel developer at Freescale



\
 
 \ /
  Last update: 2011-08-23 21:13    [W:1.812 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site