Messages in this thread | | | Date | Tue, 23 Aug 2011 18:54:53 +0200 | From | Andrea Arcangeli <> | Subject | Re: [PATCH] thp: tail page refcounting fix |
| |
On Wed, Aug 24, 2011 at 01:45:15AM +0900, Minchan Kim wrote: > Nice idea!
Thanks! It felt natural to account the tail refcounts in page_tail->_count, so they were already there and it was enough to add the page_mapcount(head_page) to the page_tail->_count. But there's no particular reason we had to do the tail_page refcounting in the ->_page field before the split...
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com> > > The code looks good to me.
Thanks a lot for the quick review.
> The nitpick is about naming 'foll'. > What does it mean? 'follow'? > If it is, I hope we use full name. > Regardless of renaming it, I am okay the patch.
Ok the name comes from FOLL_GET. Only code paths marked by checking FOLL_GET are allowed to call get_page_foll(). Anything else can't.
mm/*memory.c:
if (flags & FOLL_GET) get_page_foll(page);
| |