lkml.org 
[lkml]   [2011]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/16] freezer: make exiting tasks properly unfreezable
Hi.

Not a comment, but the question. Probably falls into the "read the
whole series" category too.

On 08/19, Tejun Heo wrote:
>
> There's no point in freezing an exiting task.

This is not clear to me. Probably this is fine, I do not know what
the callers of freeze_processes() actually expect.

> @@ -915,6 +913,12 @@ NORET_TYPE void do_exit(long code)
>
> ptrace_event(PTRACE_EVENT_EXIT, code);
>
> + /*
> + * With ptrace notification done, there's no point in freezing from
> + * here on. Disallow freezing.
> + */
> + current->flags |= PF_NOFREEZE;

OK, but what PF_NOFREEZE actually means?

Apart from "dont try to freeze" it means "no need to freeze", yes?

IOW, try_to_freeze_tasks() can succeed even if we have a lot of
exitinig task which can make some activity, say, disk i/o. Is this
correct?

Once again, I do not understand the problem-space at all, jus I am
curious.

Thanks,

Oleg.



\
 
 \ /
  Last update: 2011-08-23 17:57    [from the cache]
©2003-2011 Jasper Spaans