Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 4/7] VFS: Add generic_file_llseek_size | Date | Tue, 23 Aug 2011 14:51:56 +0200 |
| |
On Monday 22 August 2011, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > Add a generic_file_llseek variant to the VFS that allows passing in > the current file size, instead of always using inode->i_size. > This can be used to eliminate some cut'n'paste seek code in ext4. > > Signed-off-by: Andi Kleen <ak@linux.intel.com>
Ah, very nice. I think you can use the same trick to remove duplication in default_llseek by always setting the limit to MAX_LFS_FILESIZE.
Arnd
| |