lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv4 1/4] usb: Provide usb_speed_string() function
    On Mon, 22 Aug 2011, Michal Nazarewicz wrote:

    > From: Michal Nazarewicz <mina86@mina86.com>
    >
    > In a few places in the kernel, the code prints
    > a human-readable USB device speed (eg. "high speed").
    > This involves a switch statement sometimes wrapped
    > around in ({ ... }) block leading to code repetition.
    >
    > To mitigate this issue, this commit introduces
    > usb_speed_string() function, which returns
    > a human-readable name of provided speed.
    >
    > It also changes a few places switch was used to use
    > this new function. This changes a bit the way the
    > speed is printed in few instances at the same time
    > standardising it.

    > --- a/drivers/usb/Makefile
    > +++ b/drivers/usb/Makefile
    > @@ -51,3 +51,6 @@ obj-$(CONFIG_USB_MUSB_HDRC) += musb/
    > obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/
    > obj-$(CONFIG_USB_OTG_UTILS) += otg/
    > obj-$(CONFIG_USB_GADGET) += gadget/
    > +
    > +obj-$(CONFIG_USB) += common.o
    > +obj-$(CONFIG_USB_GADGET) += common.o

    Will this cause problems? For example, what if CONFIG_USB is Y and
    CONFIG_USB_GADGET is M?

    Also, it seems a little silly to have an entire kernel module devoted
    to a single, little function. This is a symptom of the difficulty of
    sharing code between the host-side and gadget-side USB stacks.

    Alan Stern



    \
     
     \ /
      Last update: 2011-08-22 19:31    [W:0.023 / U:31.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site