lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] debug-pagealloc: use plain __ratelimit() instead of printk_ratelimit()
    Date
    printk_ratelimit() should not be used, because it shares ratelimiting
    state with all other unrelated printk_ratelimit() callsites.

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    ---
    mm/debug-pagealloc.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/mm/debug-pagealloc.c b/mm/debug-pagealloc.c
    index a1e3324..a4b6d70 100644
    --- a/mm/debug-pagealloc.c
    +++ b/mm/debug-pagealloc.c
    @@ -2,6 +2,7 @@
    #include <linux/mm.h>
    #include <linux/page-debug-flags.h>
    #include <linux/poison.h>
    +#include <linux/ratelimit.h>

    static inline void set_page_poison(struct page *page)
    {
    @@ -59,6 +60,7 @@ static bool single_bit_flip(unsigned char a, unsigned char b)

    static void check_poison_mem(unsigned char *mem, size_t bytes)
    {
    + static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 10);
    unsigned char *start;
    unsigned char *end;

    @@ -74,7 +76,7 @@ static void check_poison_mem(unsigned char *mem, size_t bytes)
    break;
    }

    - if (!printk_ratelimit())
    + if (!__ratelimit(&ratelimit))
    return;
    else if (start == end && single_bit_flip(*start, PAGE_POISON))
    printk(KERN_ERR "pagealloc: single bit error\n");
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-08-22 18:29    [W:3.322 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site