lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 2/4] sound/soc/ep93xx/ep93xx-i2s.c: add missing kfree
On Friday, August 19, 2011 11:13 PM, Julia Lawall wrote:
>
> Introduce a new label that includes kfree and jump to that one.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> expression E1!=0,E2,E3,E4;
> statement S;
> iterator I;
> @@
>
> (
> if (...) { ... when != kfree(x)
> when != x = E3
> when != E3 = x
> * return ...;
> }
> ... when != x = E2
> when != I(...,x,...) S
> if (...) { ... when != x = E4
> kfree(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> sound/soc/ep93xx/ep93xx-i2s.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/ep93xx/ep93xx-i2s.c b/sound/soc/ep93xx/ep93xx-i2s.c
> index 56efa0c..099614e 100644
> --- a/sound/soc/ep93xx/ep93xx-i2s.c
> +++ b/sound/soc/ep93xx/ep93xx-i2s.c
> @@ -385,14 +385,14 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res) {
> err = -ENODEV;
> - goto fail;
> + goto fail_free_info;
> }
>
> info->mem = request_mem_region(res->start, resource_size(res),
> pdev->name);
> if (!info->mem) {
> err = -EBUSY;
> - goto fail;
> + goto fail_free_info;
> }
>
> info->regs = ioremap(info->mem->start, resource_size(info->mem));
> @@ -435,6 +435,7 @@ fail_unmap_mem:
> iounmap(info->regs);
> fail_release_mem:
> release_mem_region(info->mem->start, resource_size(info->mem));
> +fail_free_info:
> kfree(info);
> fail:
> return err;

Looks correct to me...

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>


\
 
 \ /
  Last update: 2011-08-22 18:27    [W:0.047 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site