lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value
    Date
    From: Julia Lawall <julia@diku.dk>

    Test the just-initialized value rather than some other one.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @r@
    identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
    statement S;
    @@

    x = f(...);
    (
    if (\(x == NULL\|IS_ERR(x)\)) S
    |
    *if (\(y == NULL\|IS_ERR(y)\))
    { ... when != x
    return ...; }
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/net/wireless/mwifiex/scan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
    index b28241c..d3111c9 100644
    --- a/drivers/net/wireless/mwifiex/scan.c
    +++ b/drivers/net/wireless/mwifiex/scan.c
    @@ -1480,7 +1480,7 @@ mwifiex_update_curr_bss_params(struct mwifiex_private *priv,
    return -ENOMEM;
    }
    beacon_ie = kzalloc(ie_len, GFP_KERNEL);
    - if (!bss_desc) {
    + if (!beacon_ie) {
    dev_err(priv->adapter->dev, " failed to alloc bss_desc\n");
    return -ENOMEM;
    }


    \
     
     \ /
      Last update: 2011-08-22 16:03    [W:0.022 / U:0.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site