lkml.org 
[lkml]   [2011]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] coredump: fix wrong comments on core limits of pipe coredump case
Ah, I thought you are going to re-do this patch...

On 08/22, bookjovi@gmail.com wrote:
>
> Only core limit 1 can skip dump in ispipe case, not 0.

Yes, but this is (almost) internal hack we use to avoid the recursive
crashes.

> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -2163,7 +2163,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
> * we're not writing to the file system, but we use
> * cprm.limit of 1 here as a speacial value. Any
> * non-1 limit gets set to RLIM_INFINITY below, but
> - * a limit of 0 skips the dump. This is a consistent
> + * a limit of 1 skips the dump. This is a consistent

I'd suggest to simple remove the "skips the dump" part.

To me, we can also remove the "Note that we use task_tgid_vnr" part,
but feel free to ignore. Every user of task_tgid_vnr() could have the
same comment.

Oleg.



\
 
 \ /
  Last update: 2011-08-22 15:37    [W:0.292 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site