lkml.org 
[lkml]   [2011]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] arch/powerpc/platforms/cell/iommu.c: add missing of_node_put
    Date
    From: Julia Lawall <julia@diku.dk>

    np is initialized to the result of calling a function that calls
    of_node_get, so of_node_put should be called before the pointer is dropped.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e,e1,e2;
    @@

    * e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
    ... when != of_node_put(e)
    when != true e == NULL
    when != e2 = e
    e = e1
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    arch/powerpc/platforms/cell/iommu.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
    index 26a0671..d0c5dfd 100644
    --- a/arch/powerpc/platforms/cell/iommu.c
    +++ b/arch/powerpc/platforms/cell/iommu.c
    @@ -1038,6 +1038,8 @@ static int __init cell_iommu_fixed_mapping_init(void)

    /* The fixed mapping is only supported on axon machines */
    np = of_find_node_by_name(NULL, "axon");
    + of_node_put(np);
    +
    if (!np) {
    pr_debug("iommu: fixed mapping disabled, no axons found\n");
    return -1;


    \
     
     \ /
      Last update: 2011-08-21 18:13    [W:0.018 / U:0.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site