lkml.org 
[lkml]   [2011]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] sound/soc/mxs/mxs-saif.c: add missing kfree
    On Sat, Aug 20, 2011 at 08:12:40AM +0200, Julia Lawall wrote:

    > diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
    > index 0b3adae..4a17bc8 100644
    > --- a/sound/soc/mxs/mxs-saif.c
    > +++ b/sound/soc/mxs/mxs-saif.c
    > @@ -523,8 +523,10 @@ static int mxs_saif_probe(struct platform_device *pdev)
    > if (!saif)
    > return -ENOMEM;
    >
    > - if (pdev->id >= ARRAY_SIZE(mxs_saif))
    > - return -EINVAL;
    > + if (pdev->id >= ARRAY_SIZE(mxs_saif)) {
    > + ret = -EINVAL;
    > + goto failed;
    > + }
    > mxs_saif[pdev->id] = saif;

    Thanks, Julia. May I suggest to simple move the id-check before the
    allocation?

    Regards,

    Wolfram

    --
    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-08-20 15:47    [W:0.021 / U:0.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site