Messages in this thread | | | Date | Tue, 2 Aug 2011 16:35:05 +0900 | Subject | Re: [PATCH v3 0/6] notifier error injection | From | Akinobu Mita <> |
| |
2011/8/1 Pavel Machek <pavel@ucw.cz>: > Hi! > >> This provides kernel modules that can be used to test the error handling >> of notifier call chain failures by injecting artifical errors to the >> following notifier chain callbacks. >> >> * CPU notifier >> * PM notifier >> * memory hotplug notifier >> * powerpc pSeries reconfig notifier > ... > >> 11 files changed, 680 insertions(+), 38 deletions(-) > > Do we really need this debugging code in mainline? How many bugs did > it find?
I'm seeing a memory hotplug related bug but it also can be reproducible without this feature. Repeatedly online/offline memory with attached memory-hotplug.sh under disk activity like kernel build can easily cause Oopses.
Aside from that, I didn't find any bugs but I still think this feature is useful for testing and it just add a little complexity to exiting code. (Maybe I need to prove it by finding more bugs) [unhandled content-type:application/x-sh][unhandled content-type:application/octet-stream] | |