Messages in this thread | | | Date | Tue, 2 Aug 2011 09:26:14 +0200 | From | Jens Axboe <> | Subject | Re: linux-next: build warning after merge of the moduleh tree |
| |
On 2011-08-01 05:23, Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > block/bsg-lib.c:75:1: warning: data definition has no type or storage class > block/bsg-lib.c:75:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > block/bsg-lib.c:75:1: warning: parameter names (without types) in function declaration > block/bsg-lib.c:164:1: warning: data definition has no type or storage class > block/bsg-lib.c:164:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > block/bsg-lib.c:164:1: warning: parameter names (without types) in function declaration > block/bsg-lib.c:210:1: warning: data definition has no type or storage class > block/bsg-lib.c:210:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > block/bsg-lib.c:210:1: warning: parameter names (without types) in function declaration > block/bsg-lib.c:244:1: warning: data definition has no type or storage class > block/bsg-lib.c:244:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > block/bsg-lib.c:244:1: warning: parameter names (without types) in function declaration > block/bsg-lib.c:297:1: warning: data definition has no type or storage class > block/bsg-lib.c:297:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > block/bsg-lib.c:297:1: warning: parameter names (without types) in function declaration > > This is an interaction with commit aa387cc89567 ("block: add bsg helper > library") from the block tree. That file should have included module.h > but now would need export.h it seems (just uses EXPORTSYMBOL_GPL). > > I applied the following as a merge fix patch:
Thanks, will you carry this until things are merged? Not easy for me to fix up.
-- Jens Axboe
| |