lkml.org 
[lkml]   [2011]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/11] kernel/kfifo.c: trivial: use BUG_ON
On Tue, Aug 02, 2011 at 09:27:38PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Allow the function to return 0 when 0 elements are asked for rather than
> crashing the kernel with BUG.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>

Reviewed-by: Andrea Righi <andrea@betterlinux.com>

Thanks,
-Andrea

>
> ---
> var/julia/linuxcopy/kernel/kfifo.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff -u -p a/kernel/kfifo.c b/kernel/kfifo.c
> index 01a0700..9f928ef 100644
> --- a/var/linuxes/linux-next/kernel/kfifo.c
> +++ b/var/julia/linuxcopy/kernel/kfifo.c
> @@ -562,9 +562,6 @@ EXPORT_SYMBOL(__kfifo_to_user_r);
> unsigned int __kfifo_dma_in_prepare_r(struct __kfifo *fifo,
> struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
> {
> - if (!nents)
> - BUG();
> -
> len = __kfifo_max_r(len, recsize);
>
> if (len + recsize > kfifo_unused(fifo))
> @@ -586,9 +583,6 @@ EXPORT_SYMBOL(__kfifo_dma_in_finish_r);
> unsigned int __kfifo_dma_out_prepare_r(struct __kfifo *fifo,
> struct scatterlist *sgl, int nents, unsigned int len, size_t recsize)
> {
> - if (!nents)
> - BUG();
> -
> len = __kfifo_max_r(len, recsize);
>
> if (len + recsize > fifo->in - fifo->out)


\
 
 \ /
  Last update: 2011-08-02 22:13    [from the cache]
©2003-2011 Jasper Spaans