lkml.org 
[lkml]   [2011]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE()
    From
    Hi,

    On Tue, Aug 2, 2011 at 1:33 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
    > On Fri, Jul 29, 2011 at 03:51:37PM +0200, Michal Marek wrote:
    >> Replace the config_is_*() macros with a variant that allows for grepping
    >> for usage of CONFIG_* options in the code. Usage:
    >>
    >>   if (IS_ENABLED(CONFIG_NUMA))
    >>
    >> or
    >>
    >>   #if IS_ENABLED(CONFIG_NUMA)
    >>
    >> The IS_ENABLED() macro evaluates to 1 if the argument is set (to either 'y'
    >> or 'm'), IS_BUILTIN() tests if the option is 'y' and IS_MODULE() test if
    >> the option is 'm'. Only boolean and tristate options are supported.
    >>
    >> Signed-off-by: Michal Marek <mmarek@suse.cz>
    >> ---
    >>
    >> Everybody happy with the above naming?
    > Naming is good - has my ack.
    >
    >
    >>
    >> ---
    >>  Makefile                   |    2 +-
    >>  include/linux/kconfig.h    |   32 ++++++++++++++++++++
    >>  scripts/kconfig/confdata.c |   71 ++++++++-----------------------------------
    >>  3 files changed, 47 insertions(+), 58 deletions(-)
    >>  create mode 100644 include/linux/kconfig.h
    >>
    >> diff --git a/Makefile b/Makefile
    >> index afb8e0d..bd7629b 100644
    >> --- a/Makefile
    >> +++ b/Makefile
    >> @@ -360,7 +360,7 @@ CFLAGS_GCOV       = -fprofile-arcs -ftest-coverage
    >>  LINUXINCLUDE    := -I$(srctree)/arch/$(hdr-arch)/include \
    >>                     -Iarch/$(hdr-arch)/include/generated -Iinclude \
    >>                     $(if $(KBUILD_SRC), -I$(srctree)/include) \
    >> -                   -include include/generated/autoconf.h
    >> +                   -include $(srctree)/include/linux/kconfig.h
    >
    > If we do it like this then how about adding this to autoconf.h and avoid the extra file,
    > and the extra flag to gcc?
    >
    That would be intrusive for non-Linux users of kconfig. You would have
    to hardcode a <linux/kconfig.h> in autoconf.h, which mean other
    project would have to either mirror the Linux include tree structure,
    or modify kconfig for the desired include path, if the feature is
    desired at all. As I see it, Linux, through Kbuild, is a user of
    kconfig.

    I might send a patch to conditionally generate the __enable_<FOO>
    stuff so that other project have the choice to use this feature or not
    (and avoid namespace utilization if not), but that's low priority.

    - Arnaud
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-08-02 19:53    [W:0.024 / U:305.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site