Messages in this thread | | | Date | Tue, 2 Aug 2011 14:35:54 +0300 | From | Dan Carpenter <> | Subject | Re: USB related "unable to handle kernel paging request" in 3.0.0-rc7 |
| |
On Tue, Aug 02, 2011 at 12:40:28PM +0200, Florian Mickler wrote: > This should fix it. >
That's not right. You should just make .size_of_priv = 20 with a comment.
Btw vp7045_properties is declared twice so it's confusing. Initially, I saw the first declaration so I thought .size_of_priv was zero. I don't understand why sparse doesn't warn about that. Could you fix that as well?
Also I did notice at first that you were the person who added the .size_of_priv change so that's why I thought someone else must use that function.
regards, dan carpenter
| |