lkml.org 
[lkml]   [2011]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/11] arch/m32r/kernel/smp.c: trivial: use BUG_ON
(2011/08/02 19:35), Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
>
> @@ identifier x; @@
> -if (!x) BUG();
> +BUG_ON(!x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>

Indeed.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


>
> ---
> arch/m32r/kernel/smp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
> --- a/arch/m32r/kernel/smp.c
> +++ b/arch/m32r/kernel/smp.c
> @@ -327,8 +327,7 @@ void smp_flush_tlb_page(struct vm_area_s
> cpumask_clear_cpu(cpu_id, &cpu_mask);
>
> #ifdef DEBUG_SMP
> - if (!mm)
> - BUG();
> + BUG_ON(!mm);
> #endif
>
> if (*mmc != NO_CONTEXT) {
>
>
>




\
 
 \ /
  Last update: 2011-08-02 12:57    [from the cache]
©2003-2011 Jasper Spaans