Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 6/11] drivers/iommu/iommu.c: trivial: use BUG_ON | Date | Tue, 2 Aug 2011 12:34:59 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
Use BUG_ON(x) rather than if(x) BUG();
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x);
@@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/iommu/iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -27,8 +27,7 @@ static struct iommu_ops *iommu_ops; void register_iommu(struct iommu_ops *ops) { - if (iommu_ops) - BUG(); + BUG_ON(iommu_ops); iommu_ops = ops; }
| |