lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Sound, Cirrus: Remove redundant check
Date
On Fri, Aug 19, 2011 at 6:00 PM, Jesper Juhl <jj@chaosbits.net> wrote:
> The variable 'idxp' is a pointer to 'unsigned int', so the value
> obtained when dereferencing it is always greater than or equal to
> 0. Testing this is redundant.

snd_hda_get_conn_index() can return a negative number, so maybe *idxp
should be a pointer to a signed int?

--
Timur Tabi
Linux kernel developer at Freescale


\
 
 \ /
  Last update: 2011-08-20 02:19    [W:0.048 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site