Messages in this thread | | | From | Tabi Timur-B04825 <> | Subject | Re: [PATCH] Sound, Cirrus: Remove redundant check | Date | Sat, 20 Aug 2011 00:16:57 +0000 |
| |
On Fri, Aug 19, 2011 at 6:00 PM, Jesper Juhl <jj@chaosbits.net> wrote: > The variable 'idxp' is a pointer to 'unsigned int', so the value > obtained when dereferencing it is always greater than or equal to > 0. Testing this is redundant.
snd_hda_get_conn_index() can return a negative number, so maybe *idxp should be a pointer to a signed int?
-- Timur Tabi Linux kernel developer at Freescale
| |