lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 14/43] microblaze: Don't reimplement force_sigsegv()
    Date
    From: Matt Fleming <matt.fleming@intel.com>

    Instead of open coding the sequence from force_sigsegv() just call
    it. This also fixes a bug because we were modifying ka->sa.sa_handler
    (which is a copy of sighand->action[]), whereas the intention of the
    code was to modify sighand->action[] directly.

    As the original code was working with a copy it had no effect on
    signal delivery.

    Acked-by: Oleg Nesterov <oleg@redhat.com>
    Acked-by: Michal Simek <monstr@monstr.eu>
    Signed-off-by: Matt Fleming <matt.fleming@intel.com>
    ---
    arch/microblaze/kernel/signal.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c
    index 5996711..90de06d 100644
    --- a/arch/microblaze/kernel/signal.c
    +++ b/arch/microblaze/kernel/signal.c
    @@ -270,9 +270,7 @@ static void setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
    return;

    give_sigsegv:
    - if (sig == SIGSEGV)
    - ka->sa.sa_handler = SIG_DFL;
    - force_sig(SIGSEGV, current);
    + force_sigsegv(sig, current);
    }

    /* Handle restarting system calls */
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-08-19 18:59    [W:0.022 / U:212.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site