[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2 42/43] dlm: Remove another superfluous call to recalc_sigpending()
From: Matt Fleming <>

recalc_sigpending() is called within sigprocmask(), so there is no
need call it again after sigprocmask() has returned. Furthermore, the
call to recalc_sigpending() could race with signal_wake_up() because
it isn't called with sighand->siglock held. I must have missed this
call when removing the other recalc_sigpending() in commit
4bcad6c1ef53 ("dlm: Remove superfluous call to recalc_sigpending())".

Cc: Christine Caulfield <>
Acked-by: David Teigland <>
Acked-by: Oleg Nesterov <>
Signed-off-by: Matt Fleming <>
fs/dlm/user.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index d8ea607..b38b122 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -678,7 +678,6 @@ static int device_close(struct inode *inode, struct file *file)
device_remove_lockspace() */

sigprocmask(SIG_SETMASK, &tmpsig, NULL);
- recalc_sigpending();

return 0;

 \ /
  Last update: 2011-08-19 18:51    [W:0.138 / U:11.560 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site