lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled
From
Date
On Fri, 2011-08-19 at 18:55 +0300, Artem Bityutskiy wrote:
> On Thu, 2011-08-11 at 12:29 +0200, Michal Marek wrote:
> > With
> > $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
> > # CONFIG_UBIFS_FS_DEBUG is not set
> > CONFIG_DYNAMIC_DEBUG=y
> >
> > Debug messages are kept in the object files due to the
> > dynamic_pr_debug() macro, even if they are never going to be printed:
> > $ make fs/ubifs/super.o
> > $ strings fs/ubifs/super.o | grep 'compiled on'
> > compiled on: Aug 11 2011 at 12:21:38
> >
> > Use plain printk to fix this.
> >
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> Good catch, thanks! Pushed to ubifs-2.6.git, thanks!

There is a similar issue in UBI - just fixed it. I'll send this to Linus
soon, as this is a regression (blown-up binaries even though debugging
is disabled).

--
Best Regards,
Artem Bityutskiy



\
 
 \ /
  Last update: 2011-08-19 18:09    [W:0.718 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site