lkml.org 
[lkml]   [2011]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2] usb: gadget: get rid of USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED
Date
From
On Fri, 19 Aug 2011 13:13:41 +0200, Sebastian Andrzej Siewior  
<bigeasy@linutronix.de> wrote:
> There are three speeds:
> - the max speed the UDC supports i.e. HS (no field for that?)

Yep, the field seems to be missing for that one. We have is_dualspeed and
comment in gadget_is_superspeed() says about is_superspeed but that does
not exist.

> - the max speed the gadget / function driver support i.e. SS
> (driver->max_speed ?)

Actually “max_speed” is only in usb_composite_driver structure.
usb_gadget_driver has only “speed” and it's description says that it is
the “highest speed the driver handles.” Because of that description I've
assumed that it is UDC driver's responsibility to figure out maximum speed
it can use.

> - the speed the UDC is connected at the moment i.e. FS. (gadget->speed)

OK, I see my mistake. I misinterpreted gadget->speed as the max speed
gadget supports.

So in the end, it would seem to me that we need to do the following is
usb_gadget_probe_direvr() before passing the usb_gadget_driver to the
usb_gadegt's bind:

if (driver->speed == USB_SPEED_SUPER && !gadget_is_superspeed(udc->gadget))
driver->speed = USB_SPEED_HIGH;
if (driver->speed == USB_SPEED_HIGH && !gadget_is_dualspeed(udc->gadget))
driver->speed = USB_SPEED_FULL;

(Although I'm not sure about USB_SPEED_FULL vs. USB_SPEED_LOW.)

Either than, or make sure that all UDC drivers handle correctly gadgets
that declare speed as highest of what the UDC can handle.


At the moment however, gadget_is_superspeed() is implemented using #ifdefs
(which I missed before) so we need to add a is_superspeed to usb_gadget
structure. Or maybe better yet get rid of is_dualspeed and add max_speed?


Does what I'm writing make sense at all?

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-19 14:17    [W:0.081 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site