lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags
From
Date
On Thu, 2011-08-18 at 00:26 -0700, Joe Perches wrote:
> On Wed, 2011-08-17 at 23:48 -0700, Jeff Kirsher wrote:
> > From: Bruce Allan <bruce.w.allan@intel.com>
> >
> > Commit 2011247 introduced additional style checks for signature tags in
> > patches which is good. Unfortunately, now whenever patches are checked
> > by piping the output of 'git show' or 'stg show' through checkpatch it
> > warns not to use whitespace before all signature tags since these (and the
> > rest of the patch description) are indented. Remove this test/warning.
>
> I think this is not a good idea.
>
> checkpatch is meant for patches not git log output.
> indenting signatures can cause other problems later.
>
> I think you can avoid this easily by using checkpatch
> option --ignore=BAD_SIGN_OFF when using git log output
> as input.

The problem I have with this is that the sign-off's are not bad, they
are by default indented by 'git show' or 'stg show' so checkpatch.pl
should handle the "default" formatting of git/stg and if there is
additional indenting not expected, then the sign-off's should be
considered bad. If this option is added, then if there were "real"
problems with the sign-off, it would not be displayed.

>
> You could also use:
>
> git log --format="commit %H%nAuthor: %an <%ae>%nDate: %aD%n%n%s%n%n%b"
>
> so that you get the current default --format=medium
> output without indenting the commit log body.
>
>

Even doing this does not resolve the "false" warnings" that
checkpatch.pl produces regarding the sign-off's.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-08-18 09:49    [W:0.063 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site