lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sparse: always enable endian checks
From
On Tue, Aug 16, 2011 at 2:33 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Mon, Aug 15, 2011 at 12:04:41PM -0400, Pavel Roskin wrote:
>> Checks enabled by __CHECK_ENDIAN__ produce less than a half of the
>> sparse warnings.  For instance, the allyesconfig configuration on
>> linux-next (tag next-20110812) produces on x86_64:
>>
>>                  no __CHECK_ENDIAN__   with __CHECK_ENDIAN__
>> stderr bytes:    1155037               1992954 (73% increase)
>> stderr lines:    10716                 18657   (74% increase)
>> affected files:  1191                  1458    (22% increase)
>>
>> It is no longer true that __CHECK_ENDIAN__ produces so many warnings
>> that other sparse warnings drown in the noise.
>>
>> Janitors going through the whole tree are already prepared to search for
>> the warnings they want to fix.
>>
>> The main point of this patch is to make sure that developers of a
>> particular driver who use sparse rarely get all the warnings for their
>> code even if they forget to specify __CHECK_ENDIAN__ or mistype it.
>>
>> Some developers actually added __CHECK_ENDIAN__ to the driver makefiles
>> so they don't forget to use it.  Remove them now.
>>
>> Remove all references to __CHECK_ENDIAN__ from the documentation except
>> the Chinese version, which would need to be updated separately.
>>
>> Signed-off-by: Pavel Roskin <proski@gnu.org>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Maybe ask Michal to merge it?
>

ping Michal... :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-08-18 12:13    [W:0.048 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site