lkml.org 
[lkml]   [2011]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags
From
Date
On Thu, 2011-08-18 at 01:56 -0700, Joe Perches wrote:
> On Thu, 2011-08-18 at 01:43 -0700, Jeff Kirsher wrote:
> > I understand what your saying, and I think that your suggestion about
> > possibly implementing a "--input=git" option to checkpatch.pl might be a
> > happy middle ground to resolve the numerous false warnings this check
> > produces.
>
> As far as I can tell, --ignore= suffices.
>
> If you really want to use checkpatch for checking
> already committed patches, maybe you should not
> use git log but use git format-patch instead.
>
> $ git format-patch -1 --stdout | ./scripts/checkpatch.pl -
>
> That works without any problems.

Thank you Joe, I will take a look at how we validate patches with
checkpatch.pl and hopefully we can reduce the time I take reviewing
checkpatch.pl warnings.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-08-18 11:23    [W:0.045 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site