Messages in this thread | | | Date | Wed, 17 Aug 2011 13:50:23 +0300 | From | Dmitry Kasatkin <> | Subject | Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib |
| |
On 16/08/11 03:57, James Morris wrote: > On Thu, 11 Aug 2011, Dmitry Kasatkin wrote: > >> From: Dmitry Kasatkin <dmitry.kasatkin@nokia.com> >> >> Adds the multi-precision-integer maths library which was originally taken >> from GnuPG and ported to the kernel by (among others) David Howells. >> This version is taken from Fedora kernel 2.6.32-71.14.1.el6. > > First thing -- this code needs to be formatted using kernel coding style. > > > - James
The code is inherited from GnuPG which does not follow kernel coding standard. There are lots of "checkpatch" errors and warnings.. Do you say it must be reformatted?
- Dmitry
| |