lkml.org 
[lkml]   [2011]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: pstore: change mutex locking to spin_locks
From
Date
On Wed, 2011-08-17 at 14:22 -0700, Andrew Morton wrote:
> It's still bad if lockdep is enabled. See
> kernel/lockdep.c:lock_acquire() and lock_release(). They aren't
> NMI-safe.

Good thing nmi_enter() does lockdep_disable() and makes lock_acquire()
bail on if (current->lockdep_recursion).

Still the fact that pstore needs locks from NMI context (let alone tried
to use a mutex) makes one think one should avoid it like the plague.



\
 
 \ /
  Last update: 2011-08-17 23:45    [W:0.112 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site