Messages in this thread | | | Date | Wed, 17 Aug 2011 12:25:27 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] usb: gadget: get rid of USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED |
| |
On Wed, 17 Aug 2011, Michal Nazarewicz wrote:
> >>>> --- a/drivers/usb/gadget/file_storage.c > >>>> +++ b/drivers/usb/gadget/file_storage.c > >>>> @@ -3562,11 +3562,7 @@ static void fsg_resume(struct usb_gadget > >>>> *gadget) > >>>> static struct usb_gadget_driver fsg_driver = { > >>>> -#ifdef CONFIG_USB_GADGET_DUALSPEED > >>>> .speed = USB_SPEED_HIGH, > >>>> -#else > >>>> - .speed = USB_SPEED_FULL, > >>>> -#endif > >>>> .function = (char *) fsg_string_product, > >>>> .unbind = fsg_unbind, > >>>> .disconnect = fsg_disconnect, > > >>> You mustn't remove the .speed field entirely. Set it to > >>> USB_SPEED_HIGH. > > >> Please note that the field is not in fact removed. > > > No, but you removed its initializer and as a result, it will be set to > > 0 whereas it should be set to USB_SPEED_HIGH. > > The initializer is still there. ;) Only the “#” lines and the initializer > in the “#else” part are removed.
I must be going selectively blind. Never mind...
Alan Stern
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |