lkml.org 
[lkml]   [2011]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] i2c: tegra: Check for overflow errors with BUG_ON.
    On Mon, Aug 15, 2011 at 06:32:16PM -0700, Doug Anderson wrote:
    > This change doesn't fix any known problems but turns
    > on the overflow detection feature of the i2c controller
    > in the hopes of flushing out any current (or future)
    > bugs in the i2c driver.
    >
    > Inspired by a change on nvidia's git server:
    > http://nv-tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=commit;h=266d1b7397284505e55d06254b497cb32be07b69
    >
    > Signed-off-by: Doug Anderson <dianders@chromium.org>

    Reviewed-by: Felipe Balbi <balbi@ti.com>

    > ---
    > This takes Felipe Balbi's suggestion of making the overflow
    > error non-fatal.

    the WARN() was very nice idea, I was thinking of just returning an error
    to the client, but the adition of WARN() will make it really bold ;-)

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-08-16 08:37    [W:0.023 / U:89.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site