Messages in this thread | | | Date | Mon, 15 Aug 2011 01:16:17 -0400 | Subject | Re: [PATCH 08/11] drivers/scsi: do not use EXTRA_CFLAGS | From | Arnaud Lacombe <> |
| |
Hi,
On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Usage of these flags has been deprecated for nearly 4 years by: > > commit f77bf01425b11947eeb3b5b54685212c302741b8 > Author: Sam Ravnborg <sam@neptun.(none)> > Date: Mon Oct 15 22:25:06 2007 +0200 > > kbuild: introduce ccflags-y, asflags-y and ldflags-y > > Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command > line use. By default, gmake(1) do not override command line setting, so this is > likely to result in build failure or unexpected behavior. > > Replace their usage by Kbuild's `{as,cc,ld}flags-y'. > > In the same time, do not needlessly reference $(srctree) in the -I argument. > > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: kxie@chelsio.com > Cc: James Bottomley <James.Bottomley@suse.de> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
- Arnaud
> --- > drivers/scsi/cxgbi/cxgb3i/Kbuild | 2 +- > drivers/scsi/cxgbi/cxgb4i/Kbuild | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild > index 09dbf9e..b3197c9 100644 > --- a/drivers/scsi/cxgbi/cxgb3i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild > @@ -1,3 +1,3 @@ > -EXTRA_CFLAGS += -I$(srctree)/drivers/net/cxgb3 > +ccflags-y += -Idrivers/net/cxgb3 > > obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o > diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild > index b9f4af7..4873a25 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild > @@ -1,3 +1,3 @@ > -EXTRA_CFLAGS += -I$(srctree)/drivers/net/cxgb4 > +ccflags-y += -Idrivers/net/cxgb4 > > obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o > -- > 1.7.6.153.g78432 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |